Forums » SEPHP Feature Requests

Remove dependence on CDNJS for FontAwesome in the Admin Panel

    • 171 posts
    May 4, 2020 5:20 PM EDT

    REQUEST

     

    Although a copy of FontAwesome is included in the SocialEngine installation, an external copy of FontAwesome is loaded (twice) for providing the icons in the admin panel. 

     

    This feature request is for the two lines of code that cause the FontAwesome font to be loaded from CDNJS to be removed, and replace with one line of code that loads the local copy of FontAwesome from the SocialEngine Externals directory.

     

    ADVANTAGES

    Your local installation controls the file that is served.

    It removes any privacy/security worries with using an external site.

     

    DISADVANTAGES

    The user may be required to download an extra copy of FontAwesome if they use other sites that make use of the cdnjs network. Given the small size of the file and the fact it can be cached in their browser, it's not a huge disadvantage.

     

    IMPLEMENTATION

    In /application/modules/core/layouts/scripts/admin.tpl 

     

    Remove Line 124: 

    <link rel="stylesheet" href="https://cdnjs.cloudflare.com/ajax/libs/font-awesome/4.7.0/css/font-awesome.css" />

    Remove Line 176:

    <link rel="stylesheet" href="https://cdnjs.cloudflare.com/ajax/libs/font-awesome/4.7.0/css/font-awesome.css" />

    At line 124, insert:

    <link href="/externals/font-awesome/css/all.min.css" media="screen" rel="stylesheet" type="text/css" >

    (which is the line of code used to load FontAwesome in the front-end.

     

    Ta dah.


    This post was edited by abuk at May 4, 2020 5:21 PM EDT
    • Moderator
    • 5235 posts
    May 5, 2020 5:00 AM EDT

    Very nice feature request! Well formatted and very easy to know exactly what you want. I'll come back to this one as it is a good idea.